[Kde-games-devel] Review Request 127401: [kmines] Remove unused deps

[Frederik Schwarzer]

> On March 20, 2016, 10:24 a.m., Frederik Schwarzer wrote:
> > CMakeLists.txt, line 10
> > <https://git.reviewboard.kde.org/r/127401/diff/1/?file=453392#file453392line10>
> >
> >     You keep Qml here but remove it from the linker command further down. On purpose?
> 
> Andreas Sturmlechner wrote:
>     Yes, I've kept it there because configure will still fail without Qml even when it is not used (dependency drawn in by libkdegames)

Hmm, here it configures, compiles and runs fine without it. What's the complete error message?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127401/#review93764
-----------------------------------------------------------


On March 16, 2016, 8:54 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127401/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 8:54 p.m.)
> 
> 
> Review request for KDE Games and Frederik Schwarzer.
> 
> 
> Repository: kmines
> 
> 
> Description
> -------
> 
> Remove unused deps
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eb96e79aecf5fdb52bcfa6306cedc7974cea3e04 
> 
> Diff: https://git.reviewboard.kde.org/r/127401/diff/
> 
> 
> Testing
> -------
> 
> Builds fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/7a89ef3c/attachment-0001.html>