[Kde-games-devel] Review Request 127401: [kmines] Remove unused deps

Frederik Schwarzer schwarzer at kde.org
Sun Mar 20 10:24:57 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127401/#review93764
-----------------------------------------------------------




CMakeLists.txt (line 10)
<https://git.reviewboard.kde.org/r/127401/#comment63913>

    You keep Qml here but remove it from the linker command further down. On purpose?


- Frederik Schwarzer


On March 16, 2016, 8:54 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127401/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 8:54 p.m.)
> 
> 
> Review request for KDE Games and Frederik Schwarzer.
> 
> 
> Repository: kmines
> 
> 
> Description
> -------
> 
> Remove unused deps
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt eb96e79aecf5fdb52bcfa6306cedc7974cea3e04 
> 
> Diff: https://git.reviewboard.kde.org/r/127401/diff/
> 
> 
> Testing
> -------
> 
> Builds fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/d8a2b95f/attachment.html>


More information about the kde-games-devel mailing list