[Kde-games-devel] Review Request 127404: [kpat] Remove unused deps
Andreas Sturmlechner
andreas.sturmlechner at gmail.com
Sat Mar 19 08:10:42 UTC 2016
> On March 19, 2016, 3:59 a.m., Julian Helfferich wrote:
> > CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/127404/diff/1/?file=453400#file453400line25>
> >
> > KIO is actually used in mainwindow.cpp for loading a Game. I am not sure, why it does not complain during compilation. I can also confirm that saving/loading games still works.
> >
> > Is KIO automatically included? Maybe by one of the other components?
It is using KIO/NetAccess, but that actually comes from kdelibs4support, not KIO.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127404/#review93702
-----------------------------------------------------------
On March 16, 2016, 11:22 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127404/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 11:22 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: kpat
>
>
> Description
> -------
>
> Remove unused deps
>
>
> Diffs
> -----
>
> CMakeLists.txt 7498d154bb9d0798ae4036323e17aa1637026581
>
> Diff: https://git.reviewboard.kde.org/r/127404/diff/
>
>
> Testing
> -------
>
> Builds and runs fine without these deps.
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160319/74851a5a/attachment.html>
More information about the kde-games-devel
mailing list