[Kde-games-devel] Review Request 127404: [kpat] Remove unused deps

Julian Helfferich julian.helfferich at googlemail.com
Sat Mar 19 03:52:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127404/#review93701
-----------------------------------------------------------


Ship it!




If it compiles it is probably fine :)
I have also tested it on my computer and I can confirm: It compiles.
I also found that the deps have been introduced in the first step on porting to KDELibs5/Qt5 but it seems like they have never been used in the first place.

- Julian Helfferich


On March 16, 2016, 11:22 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127404/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 11:22 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kpat
> 
> 
> Description
> -------
> 
> Remove unused deps
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7498d154bb9d0798ae4036323e17aa1637026581 
> 
> Diff: https://git.reviewboard.kde.org/r/127404/diff/
> 
> 
> Testing
> -------
> 
> Builds and runs fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160319/c80cc0fe/attachment.html>


More information about the kde-games-devel mailing list