[Kde-games-devel] Review Request 128403: Add appdata file and rename the desktop file to org.kde scheme

[Frederik Schwarzer]

> On July 19, 2016, 8:34 p.m., Burkhard Lück wrote:
> > please review, thanks

There have been some review requests recently and I was scratsching my head a bit but never took the time to think about it (new job and new flat in new city took all my time and will do so for a few more weeks). But now I checked.

At least parts of this change have already been done in the frameworks branch of Palapeli (commit: a50fcbc0fa0) and from my understanding these changes are part of the KF5 port. If they are independent of the KF5 port, then they can mostly be cherry-picked from frameworks branch.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128403/#review97629
-----------------------------------------------------------


On July 8, 2016, 6:57 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128403/
> -----------------------------------------------------------
> 
> (Updated July 8, 2016, 6:57 a.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Stefan Majewsky.
> 
> 
> Bugs: 365218
>     http://bugs.kde.org/show_bug.cgi?id=365218
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> add simple appdata file checked with appstreamcli validate
> rename the desktop file see https://community.kde.org/Frameworks/Porting_Notes#Application
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 45f42e6 
>   src/org.kde.palapeli.appdata.xml PRE-CREATION 
>   src/org.kde.palapeli.desktop PRE-CREATION 
>   src/palapeli.desktop 5936e06 
> 
> Diff: https://git.reviewboard.kde.org/r/128403/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160719/0945ea98/attachment.html>