[Kde-games-devel] Review Request 128403: Add appdata file and rename the desktop file to org.kde scheme

[Ian Wadham]

Hi Burkhard,

Thanks very much for this contribution.  I'll reply on the KDE Games list
as I cannot review it or give it a Ship It.

On 08/07/2016, at 4:57 PM, Burkhard Lück wrote:
> This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128403/
> 
> Review request for KDE Games, Ian Wadham and Stefan Majewsky.
> By Burkhard Lück.
> Bugs: 365218
> Repository: palapeli
> Description
> 
> add simple appdata file checked with appstreamcli validate
> rename the desktop file see https://community.kde.org/Frameworks/Porting_Notes#Application
> 
> Testing
> 
> builds
> Diffs
> 
> 	• src/CMakeLists.txt (45f42e6)
> 	• src/org.kde.palapeli.appdata.xml (PRE-CREATION)
> 	• src/org.kde.palapeli.desktop (PRE-CREATION)
> 	• src/palapeli.desktop (5936e06)

These changes would have to go on Palapeli's "frameworks" branch.
Palapeli is not yet fully ported to KF5.

Also, I don't think it would be possible to release the changes until
Palapeli has been fully ported.  I am not working on that and I do not
think anyone else is.

> View Diff

So I don't think it will be possible to close
https://bugs.kde.org/show_bug.cgi?id=365218
and satisfy the user's original request to make Palapeli searchable
successfully in her distro.

FWIW, my other games - KSudoku, KGoldrunner and Kubrick - will
all have the same problem as in bug 365218 and none of them have
been fully ported to KF5.  KJumpingCube has been ported, but seems
to have no appdata file.

I was wrong in saying that none of the KDE Games have appstream
data.  A few do.  I was searching for files '*appstream*, not *appdata*.

Cheers, Ian W.