[Kde-games-devel] Review Request 128279: Fix endless loop when configured layout cannot be loaded

[Wolfgang Bauer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128279/
-----------------------------------------------------------

(Updated July 1, 2016, 11:31 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit 22600c69edbf59bc83377e3b96e3899ba935b1a3 by Wolfgang Bauer to branch Applications/16.04.


Bugs: 361132
    http://bugs.kde.org/show_bug.cgi?id=361132


Repository: kmahjongg


Description
-------

Adjust the configured layout when the default is loaded as fallback.
Otherwise loadSettings() will think that the layout has been changed in the settings, load the layout again and call startNewGame(), which in turn calls loadSettings() again, resulting in an endless loop.


Diffs
-----

  kmahjongg.cpp 58754ad 

Diff: https://git.reviewboard.kde.org/r/128279/diff/


Testing
-------

Set an invalid/inexistent file for Layout_file in kmahjonggrc and run kmahjongg.
Before it didn't even open a window, now it starts fine using the default layout.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160701/7fe7638f/attachment-0001.html>