[Kde-games-devel] Review Request 128279: Fix endless loop when configured layout cannot be loaded

[Frederik Schwarzer]

> On June 23, 2016, 9:46 p.m., Frederik Schwarzer wrote:
> > Compiled and ran it. Works on my machine. Thanks for digging into this!

@Wolfgang: Can you commit this?


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128279/#review96830
-----------------------------------------------------------


On June 23, 2016, 8:03 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128279/
> -----------------------------------------------------------
> 
> (Updated June 23, 2016, 8:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 361132
>     http://bugs.kde.org/show_bug.cgi?id=361132
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> Adjust the configured layout when the default is loaded as fallback.
> Otherwise loadSettings() will think that the layout has been changed in the settings, load the layout again and call startNewGame(), which in turn calls loadSettings() again, resulting in an endless loop.
> 
> 
> Diffs
> -----
> 
>   kmahjongg.cpp 58754ad 
> 
> Diff: https://git.reviewboard.kde.org/r/128279/diff/
> 
> 
> Testing
> -------
> 
> Set an invalid/inexistent file for Layout_file in kmahjonggrc and run kmahjongg.
> Before it didn't even open a window, now it starts fine using the default layout.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160701/632788c2/attachment.html>