[Kde-games-devel] Review Request 126788: Disable pause button when game stops

[Julian Helfferich]

> On Feb. 23, 2016, 11:12 p.m., Albert Astals Cid wrote:
> > I guess you got tired of waiting for a final review and commited, fair enough, but please now subscribe to kblocks bugs in bugs.kde.org in case you created new bugs so you see the reports and can fix them.
> 
> Julian Helfferich wrote:
>     I am now watching Zhongjie Cai, the maintainer of KBlocks on bugs.kde.org. Thus, I should receive notifications about new bug reports.
>     
>     And I do indeed intend to stay around for some time and fix any bug I might have introduced.
> 
> Albert Astals Cid wrote:
>     Great :)
> 
> Frederik Schwarzer wrote:
>     Zhongjie has not been there for over 5 years. I think it's alright to change the maintainer after such a time if someone steps up and does the work.
>     It's just a small thing but it's always nice to see ones own name there instead of just seeming to "hold the towel" for someone clearly MIA.
>     Just my thoughts. :)

Honestly, I don't mind fixing bugs without being credited as a maintainer or developer. I find it rewarding enough to know that there are users out there playing the game and that I can help make their day a little brighter :)

On the other hand, I would be happy to step up take the responsibility. KBlocks has a small, clear and very well written code base and I have become familiar with most of it.


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126788/#review92682
-----------------------------------------------------------


On Feb. 23, 2016, 2:46 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126788/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 2:46 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Pause button is disabled when a game stops. Before, the pause button was disabled when it was pressed and no game was running. To achieve this, GameLogicInterface and SingleGameInterface (and therefore also KBlocksGameLogic and KBlocksSingleGame) were made QObjects. When a single game stops, the signal KBlocksSingleGame::gameStopped() is emitted. The signal is connected to KBlocksGameLogic::stopGame() which stops all games and emits the KBlocksGameLogic::allGamesStopped() signal. This signal is then connected to KBlocksWin::onAllGamesStopped() which disables the pause button.
> 
> Additionally, KBlocksWin::onAllGamesStopped() calles Kg::difficulty()->setGameRunning(false). This fixes another minor bug: When changing the difficulty after a game was finished, a warning appeared that changing the difficulty would stop the current game even though no game was running. Now, the warning appears only when a game is running.
> 
> I have created the files GameLogicInterface.cpp and SingleGameInterface.cpp and added them to the CMakesList.txt. Before, all definitions were in GameLogicInterface.h and SingleGameInterface.h, respectively. I created the cpp files so that they are included by automoc. Is there a better way to make automoc include GameLogicInterface and SingleGameInterface?
> 
> The new signals provide the opportunity to improve the sometimes unintuitive structure of KBlocks. For example, KSingleGame stops when a new piece can not be placed. KBlocksScene, on the other hand stops when updateGame reads -1 removed lines. I will use the opportunity to extend the use of the gameStopped() signal as my next task.
> 
> 
> Diffs
> -----
> 
>   KBlocksGameLogic.h fec3658 
>   KBlocksGameLogic.cpp e455405 
>   KBlocksSingleGame.h 8efff0f 
>   KBlocksSingleGame.cpp 76647d3 
>   KBlocksWin.h 9c1616c 
>   KBlocksWin.cpp a9a2144 
> 
> Diff: https://git.reviewboard.kde.org/r/126788/diff/
> 
> 
> Testing
> -------
> 
> I played the game:
> 1) Single player:
> Started a new game after game stopped and while game was running, either once by clicking on "New Game" and by changing the difficulty.
> 2) Human vs. AI:
> Loosing game, winning game, restarting game by clicking on "New Game" and by changing the difficulty.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160225/61e0caa0/attachment.html>