[Kde-games-devel] Granatier Crashes on Master

[Julian]

Hi,

the reason was that I am not very familiar with yet with the KDE 
workflow and git cherry-picking :). I re-read the relevant pages on 
techbase and have now committed the fix also to the Applications/15.12 
branch. Should I commit also to older branches (15.08 etc)?

Best regards,
Julian

On 01/31/2016 04:49 PM, Albert Astals Cid wrote:
> El Thursday 28 January 2016, a les 07:27:12, Julian va escriure:
>> Hi,
>>
>> I can reproduce the crash and I think I have found the culprit. I will
>> post a fix on reviewboard and explain what I think is going wrong.
>> Hopefully this will fix the issue. I just don't understand yet how the
>> crash has gone unnoticed for so long. It's a good thing Frederik added
>> KCrash, I guess.
> Any reason the fix for this was only commited to master and not to the stable
> branch?
>
> Cheers,
>    Albert
>
>> Best regards,
>> Julian
>>
>> On 01/27/2016 10:06 AM, Frederik Schwarzer wrote:
>>> Intersting, when I put in some debug code, I actually get an index out
>>> of range message.
>>>
>>> [...]
>>> nIndex:  65
>>> m_blocks.size():  74
>>> nIndex:  73
>>> m_blocks.size():  74
>>> nIndex:  74
>>> m_blocks.size():  74
>>> ASSERT failure in QList<T>::operator[]: "index out of range", file
>>> /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h, line 518
>>>
>>> Am Mittwoch, 27. Januar 2016, 16:55:45 schrieb Frederik Schwarzer:
>>>> Hi,
>>>>
>>>> I just saw semi-reproducible crashes on startup in Granatier on
>>>> Master.
>>>> The crash happens on every 5th to 10th startup here and the bt is:
>>>>
>>>> #0  0x00007ffff3315507 in __GI_raise (sig=sig at entry=6) at
>>>> ../sysdeps/unix/sysv/linux/raise.c:55
>>>> #1  0x00007ffff33168da in __GI_abort () at abort.c:89
>>>> #2  0x00007ffff3faeff1 in QMessageLogger::fatal(char const*, ...)
>>>> const () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
>>>> #3  0x00007ffff3faa1b1 in qt_assert_x(char const*, char const*, char
>>>> const*, int) () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5 #4
>>>> 0x00000000004b4dc4 in QList<Block*>::operator[] (this=0x87bb80,
>>>> i=74) at /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h:518 #5
>>>> 0x00000000004a85b8 in Game::createBonus (this=0x87bb20) at
>>>> /home/fs/git/kdegames/granatier/src/game.cpp:427
>>>> #6  0x00000000004a6a07 in Game::init (this=0x87bb20) at
>>>> /home/fs/git/kdegames/granatier/src/game.cpp:210
>>>> #7  0x00000000004a4d13 in Game::Game (this=0x87bb20,
>>>> playerSettings=0x841cf0) at
>>>> /home/fs/git/kdegames/granatier/src/game.cpp:72
>>>> #8  0x0000000000502fb2 in MainWindow::initGame (this=0x87c6c0) at
>>>> /home/fs/git/kdegames/granatier/src/mainwindow.cpp:119
>>>> #9  0x0000000000503771 in MainWindow::MainWindow (this=0x87c6c0) at
>>>> /home/fs/git/kdegames/granatier/src/mainwindow.cpp:77
>>>> #10 0x00000000004ff2cb in main (argc=1, argv=0x7fffffffdd68) at
>>>> /home/fs/git/kdegames/granatier/src/main.cpp:101
>>>>
>>>> Any idea?
>>>>
>>>> Regards,
>>>> Frederik
>>>> _______________________________________________
>>>> kde-games-devel mailing list
>>>> kde-games-devel at kde.org
>>>> https://mail.kde.org/mailman/listinfo/kde-games-devel
>>> _______________________________________________
>>> kde-games-devel mailing list
>>> kde-games-devel at kde.org
>>> https://mail.kde.org/mailman/listinfo/kde-games-devel
>> _______________________________________________
>> kde-games-devel mailing list
>> kde-games-devel at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-games-devel
>