[Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools

[Ian Wadham]

> On April 5, 2016, 9:33 p.m., Ian Wadham wrote:
> > Re crashing at startup - possibly this is because of failure to load Palapeli's plugins.
> > 
> > If you have an empty user's data directory, the first thing Palapeli does is to retrieve the image-files for the sample jigsaw-puzzles (Castle  of Maintenon, etc.), then slice them into pieces, shuffle them and store them in the user's data-directory, then finally bring up the item-list of sample puzzles on the screen. So a lot of Palapeli code gets exercised the first time a user loads the game.
> > 
> > Slicing requires loading a plugin library (called libpala IIRC). Loading plugins requires kdeinit and friends to be running --- in the file-environment in which you are testing, which is not necessarily the same as the desktop's normal file-environment.  One of them (I forget which) loads the plugins.
> > 
> > You can easily check if this is what is going wrong by looking at the stderr log of Palapeli. There should be some message about failing to find or load plugins.
> 
> Ian Wadham wrote:
>     I seem to remember that (with Apple OS X and KDE 4) I needed to run kbuildsycoca after builng and installing, in my testing environment - to get the plugins to load. So try kbuildsycoca(5?).
> 
> Andreas Sturmlechner wrote:
>     My testing environment is actually my regular Gentoo environment, package manager pulls from git in that case, so that shouldn't be the problem. Anyway, kbuildsycoca5 didn't change anything unfortunately. On startup, a collection directory is created but remains empty while palapeli segfaults:
>     
>     [KCrash Handler]
>     #6  Palapeli::Puzzle::get (this=0x0, type=type at entry=Palapeli::PuzzleComponent::DirectoryStorage) at palapeli-5.9999/src/file-io/puzzle.cpp:119
>     #7  0x000000000045dc89 in Palapeli::ArchiveStorageComponent::cast (this=<optimized out>, type=Palapeli::PuzzleComponent::Metadata) at palapeli-5.9999/src/file-io/components-archivestorage.cpp:46
>     #8  0x000000000043856c in Palapeli::GamePlay::loadPreview (this=0x264ce50) at palapeli-5.9999/src/engine/gameplay.cpp:224
>     
>     I guess that would be material for a separate bug.

I think it is a bug in the porting of Palapeli to Frameworks, which was only partially done FWICR, so it is not appropriate to report it on Bugzilla. In any case, I am the only maintainer and would not be able to tackle the problem, because I work on an Apple OS X machine. Qt5 and KF5/Frameworks are not yet available to me there.

If you would like to have a go at this problem, I can help with advice on how Palapeli startup works in KDE 4 and maybe suggest a patch sometimes, but I cannot test and commit any code on the frameworks branch. If you wish to go ahead with this, I suggest we start a thread on the KDE Games list.

FWIW, re the above crash details, I cannot for the life of me see how Palapeli could have reached Palapeli::GamePlay::loadPreview() during startup. That should happen only after the collection-view has appeared and the user has selected a puzzle to solve. The procedure fetches an image of how the finished jigsaw puzzle should look.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94318
-----------------------------------------------------------


On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 10:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> Fix dependencies, search for KF5DocTools
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e 
> 
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
> 
> 
> Testing
> -------
> 
> Build is fine, runtime not (crashes at startup before and after commit)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160409/cd548aaa/attachment.html>