[Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools

[Frederik Schwarzer]

> On April 4, 2016, 9:44 a.m., Frederik Schwarzer wrote:
> > CMakeLists.txt, line 31
> > <https://git.reviewboard.kde.org/r/127568/diff/1/?file=455260#file455260line31>
> >
> >     Why do you put the KF5DocTools separate and not in the list of KF5 modules above like other games do?
> >     
> >     If there is a good reason, please tell us so we can change it for the other games as well. :)
> 
> Andreas Sturmlechner wrote:
>     Frameworks and some Applications have begun to optionalise KF5DocTools in recent times, afaik driven by kdewin, but source based packaging does appreciate that as well. So while I didn't actively move DocTools out of REQUIRED KF5 module lists so far, whenever I see it missing in there (because implied by KDELibs4Support) I add it separately as a non-required dependency. It can't be disabled via -DCMAKE_DISABLE_FIND_PACKAGES though until kdelibs4support is gone.

Ah, I did not realise that it's the non-required version of find_package.

If you have some time, could youe please write an email to the list explaining the rational so we could discuss and change it for all games accordingly? Thanks you. :)


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94231
-----------------------------------------------------------


On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 10:32 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: palapeli
> 
> 
> Description
> -------
> 
> Fix dependencies, search for KF5DocTools
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e 
> 
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
> 
> 
> Testing
> -------
> 
> Build is fine, runtime not (crashes at startup before and after commit)
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160404/44a98b75/attachment.html>