[Kde-games-devel] Review Request 127568: [palapeli] Fix dependencies, search for KF5DocTools
Frederik Schwarzer
schwarzer at kde.org
Mon Apr 4 09:44:11 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127568/#review94231
-----------------------------------------------------------
CMakeLists.txt (line 27)
<https://git.reviewboard.kde.org/r/127568/#comment64105>
Why do you put the KF5DocTools separate and not in the list of KF5 modules above like other games do?
If there is a good reason, please tell us so we can change it for the other games as well. :)
- Frederik Schwarzer
On April 3, 2016, 10:32 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127568/
> -----------------------------------------------------------
>
> (Updated April 3, 2016, 10:32 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: palapeli
>
>
> Description
> -------
>
> Fix dependencies, search for KF5DocTools
>
>
> Diffs
> -----
>
> CMakeLists.txt 6a867bf9a4f58e5a760c749c71f9c2011306115e
>
> Diff: https://git.reviewboard.kde.org/r/127568/diff/
>
>
> Testing
> -------
>
> Build is fine, runtime not (crashes at startup before and after commit)
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160404/db36164d/attachment-0001.html>
More information about the kde-games-devel
mailing list