[Kde-games-devel] Review Request 127562: [ksnakeduel] Drop unused dependencies

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127562/#review94217
-----------------------------------------------------------


Ship it!




Seems to be sound. I have also tested it and it runs fine.

Also, the frameworks branch looks very stable. I have played it for quite some time and I didn't run into any troubles. Thus, I would suggest to merge it into master. Or are there important bugs that need to be fixed first?

- Julian Helfferich


On April 3, 2016, 1:58 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127562/
> -----------------------------------------------------------
> 
> (Updated April 3, 2016, 1:58 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> Drop unused dependencies and unbreak startup using KDBusService
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 89505d1df0f4718b5268a35d5a8771266d2682ec 
>   main.cpp d675c73460fe6839227da14e72b2e424cca071fb 
> 
> Diff: https://git.reviewboard.kde.org/r/127562/diff/
> 
> 
> Testing
> -------
> 
> builds, runs fine without
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160403/e9055ac0/attachment-0001.html>