[Kde-games-devel] KNavalBattle frameworks ready for last check

[Jeremy Whiting]

I seem to be as good at losing to the easy computer as before. Looks good to me.

On Wed, Sep 30, 2015 at 12:49 PM, Frederik Schwarzer <schwarzer at kde.org> wrote:
> Am Mittwoch, 30. September 2015, 01:52:12 schrieb Albert Astals Cid:
>> I played with KNavalBattle frameworks branch for a bit and could not
>> find anything worse than the current master state.
>>
>> Please play with it and report back if you find something.
>>
>> Otherwise i'll merge it to master in 2 weeks.
>
> As far as I see it, you can also remove Phonon dependency here.
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
>
> -find_package(Phonon4Qt5 REQUIRED)
>
>
> diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
>
> -target_link_libraries(knavalbattle Qt5::Xml Qt5::Qml Qt5::Network
> KF5::I18n KF5::XmlGui KF5::Completion KF5::TextWidgets KF5::DNSSD
> Phonon::phonon4qt5 KF5KDEGames KF5::DBusAddons)
> +target_link_libraries(knavalbattle Qt5::Xml Qt5::Qml Qt5::Network
> KF5::I18n KF5::XmlGui KF5::Completion KF5::TextWidgets KF5::DNSSD
> KF5KDEGames KF5::DBusAddons)
>
>
> Regards
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel