[Kde-games-devel] KF5 ports of the games

[Frederik Schwarzer]

Am Donnerstag, 24. September 2015, 22:22:04 schrieb Ian Wadham:
> On 24/09/2015, at 9:03 PM, Albert Astals Cid wrote:
> > El Dijous, 24 de setembre de 2015, a les 20:51:33, Ian Wadham va 
escriure:
> >> Hi Frederik,
> >> 
> >> On 24/09/2015, at 3:34 PM, Frederik Schwarzer wrote:
> >>> Am Donnerstag, 24. September 2015, 03:48:23 schrieb Michael 
Palimaka:
> >>>> On 23/09/15 21:44, Frederik Schwarzer wrote:
> >>>>> Hi,
> >>>>> 
> >>>>> basically I did not follow KDE development for about three
> >>>>> years
> >>>>> now, this whole KF5 is new to me and I am not familiar with
> >>>>> how
> >>>>> things are supposed to be done now. So when I now tried to
> >>>>> build
> >>>>> KShisen (libkdegames -> libkmahjongg -> kshisen), I was
> >>>>> wondering, why it requires KF5::DNSSD. Have the requirements
> >>>>> maybe been copied from libkdegames' cmake file to all games'
> >>>>> cmake files?
> >>>> 
> >>>> A quick check of the source doesn't reveal any usage, so I
> >>>> guess
> >>>> it's an unused dependency and should be removed.
> >>> 
> >>> Yep. Same might go for Phonon, but I am not sure about that yet
> >>> because there is an unused include left (might be one of my
> >>> crimes
> >>> from a few years ago).
> >>> The question would be if that is a problem for all games. The
> >>> change in cmake was introduced by Raymond Wooninck. Maybe there
> >>> was a reason for that? I mean, compiling libkdegames needs
> >>> those as well.>> 
> >> I think the dependency on Phonon should be removed.  It was only
> >> there as a fallback, in case OpenAL and SndFile libs would be
> >> unavailable on some platform or deficient in some way for playing
> >> games sounds.
> >> 
> >> There has been no problem with OpenAL in about 4-5 years of
> >> releases and distributions of games on Linux, BSD, Windows and
> >> OSX, whereas there were problems with Phonon sound on games
> >> before that.
> >> 
> >> I suggested removing the dependency on Phonon several months
> >> ago, but Albert wanted to wait till after porting libkdegames to
> >> KF5.> 
> > The dependency to Phonon was removed almost a year ago
> > 
> > https://github.com/KDE/libkdegames/commit/5a13ecbb8a0e51159fa15513
> > dc459a0d63da974c
> > 
> > Cheers,
> > 
> >  Albert
> 
> Oh, OK.  So I wonder what dependency on Phonon Frederik was
> referring to.  Is there perchance such a dependency in libkmahjongg
> or kshisen or kmahjongg?

KShisen's cmake files have a Phonon dependency and there is even in 
include in one of the files but it is not used. Probably code rot. :)

In general I was talking about KShisen. Also with the DNSSD 
dependency.

I will take a closer look there on the weekend.

Thanks.