[Kde-games-devel] Review Request 125855: Fix bug #353845 save and load game number properly

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125855/#review87637
-----------------------------------------------------------


Please take my comments as courious questions or suggestions and not as demands to fulfill for a "ship it". :)


boardwidget.h (line 135)
<https://git.reviewboard.kde.org/r/125855/#comment60148>

    Casing: setGameNum() (as in getGameNum())
    And why not naming the variable gameNum?



kmahjongg.cpp (line 540)
<https://git.reviewboard.kde.org/r/125855/#comment60147>

    Whould it be feasable to avoid long<->qint64 conversions?



kmahjongg.cpp (lines 550 - 552)
<https://git.reviewboard.kde.org/r/125855/#comment60144>

    Please try to use the same coding style as is used in the rest of the file/project.
    Here: missing braces.



kmahjongg.cpp (line 555)
<https://git.reviewboard.kde.org/r/125855/#comment60146>

    Try to avoid whitespace changes.


- Frederik Schwarzer


On Oct. 28, 2015, 11:49 p.m., Dustin Steinack wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125855/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 11:49 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 353845
>     http://bugs.kde.org/show_bug.cgi?id=353845
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> This fix enables kmahjongg to write the current game number to the savegame file. 
> 
> The game number will be displayed in the status line if a saved games is loaded. Loading an old savegame will not change the status line.
> 
> 
> Diffs
> -----
> 
>   boardwidget.h 6e1d3f5 
>   boardwidget.cpp 6a4f033 
>   kmahjongg.cpp eb1dfa1 
> 
> Diff: https://git.reviewboard.kde.org/r/125855/diff/
> 
> 
> Testing
> -------
> 
> Loading savegame with game number included in a patched version of kmahjongg: works as expected.
> Loading savegame with game number included in an unpatched version of kmahjongg: game correctly restored, status line unaffected.
> Loading savegame with game number excluded in a patched version of kmahjongg: game correctly restored, status line unaffected.
> 
> 
> Thanks,
> 
> Dustin Steinack
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151029/ccd41d12/attachment-0001.html>