[Kde-games-devel] Review Request 125636: Fix bug #181081: "avatar is caught in an unreachable area"

[Martin Walch]

> On Okt. 28, 2015, 11:20 nachm., Albert Astals Cid wrote:
> > I don't think we have anyone that really understands this code around anymore so if you're confident this fixes the bug and commit to fix any other bugs this may break, i'd say just commit it.

Shipped. I am confident that it does not break anything, but if it does, I will try to fix it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125636/#review87631
-----------------------------------------------------------


On Okt. 29, 2015, 12:44 vorm., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125636/
> -----------------------------------------------------------
> 
> (Updated Okt. 29, 2015, 12:44 vorm.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 181081
>     http://bugs.kde.org/show_bug.cgi?id=181081
> 
> 
> Repository: kapman
> 
> 
> Description
> -------
> 
> When Kapman makes a half-turn right after taking a turn at a corner, it may
> go through an opposing wall.
> 
> This fix is rather ugly, but a better solution would probably need quite
> some refactoring. So, just fix it for now.
> 
> Also merge duplicate code paths in the same function.
> 
> BUG: 181081
> 
> 
> Diffs
> -----
> 
>   character.h 1a9fbcfcd63f3beace8149f397006c530aeed2ee 
>   character.cpp 7e6577a426faee0ec187125d8ce37088943fe4c9 
>   kapman.cpp a2bb315d3bc6d606305775e2641fc2fd6f56cb12 
> 
> Diff: https://git.reviewboard.kde.org/r/125636/diff/
> 
> 
> Testing
> -------
> 
> Played, could not trigger bug any more.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151029/0dd7703f/attachment.html>