[Kde-games-devel] Review Request 125506: marking the last move

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125506/#review87630
-----------------------------------------------------------

Ship it!


Sascha hasn't done any commit since 2010, so this is one of the manu unmaintened stuff we have.

If you really think this is a good thing, commit it (maybe wait a few more weeks in case anyone else bothers to comment)

- Albert Astals Cid


On oct. 3, 2015, 2:45 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125506/
> -----------------------------------------------------------
> 
> (Updated oct. 3, 2015, 2:45 p.m.)
> 
> 
> Review request for KDE Games and Sascha Peilicke.
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Because there is no animation for move, it's not immediately clear where the oponent played. This patch adds a second stone type which is used for the last move.
> 
> 
> Diffs
> -----
> 
>   data/themes/kigo_default.svgz 39a3989 
>   data/themes/kigo_plain.svgz 99a0dea 
>   src/game/stone.h 2702c6b 
>   src/game/stone.cpp a6d7b85 
>   src/gui/graphicsview/gamescene.cpp fb1ecfc 
>   src/gui/graphicsview/themerenderer.h b53da35 
>   src/gui/graphicsview/themerenderer.cpp 7411950 
> 
> Diff: https://git.reviewboard.kde.org/r/125506/diff/
> 
> 
> Testing
> -------
> 
> playing.
> 
> 
> File Attachments
> ----------------
> 
> kigo_default.svgz
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/cc6b8445-7fbc-4639-8210-68b22ef5659c__kigo_default.svgz
> kigo_plain.svgz
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/03/8acf715d-1502-43eb-a58b-8f4faff80c4c__kigo_plain.svgz
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151028/51d14e52/attachment.html>