[Kde-games-devel] Testing Klickety Frameworks Branch

[Albert Astals Cid]

El Tuesday 27 October 2015, a les 03:18:49, Frederik Schwarzer va escriure:
> Am Montag, 26. Oktober 2015, 23:25:08 schrieb Albert Astals Cid:
> > El Sunday 25 October 2015, a les 02:44:24, Frederik Schwarzer va
> 
> escriure:
> > > Am Samstag, 17. Oktober 2015, 14:29:45 schrieb Alexander Semke:
> > > > > KgDifficultyLevel::key (this=0x0) at
> > > > > /home/fs/git/libkdegames/kgdifficulty.cpp:132
> > > > > 132             return d->m_key;
> > > > > (gdb) bt
> > > > > #0  KgDifficultyLevel::key (this=0x0) at
> > > > > /home/fs/git/libkdegames/kgdifficulty.cpp:132
> > > > > #1  0x00007ffff7760ddd in saveLevel () at
> > > > > /home/fs/git/libkdegames/kgdifficulty.cpp:164
> > > > > [...]
> > > > > Are there ways to get more info about what is happening? At
> > > > > least
> > > > > today I could not find the cause for this.
> > > > 
> > > > This looks like a null-pointer access in kgdifficulty.cpp:164.
> > > > currentLevel() returns a null pointer.
> > > 
> > > Yep. In KSameMode no level was created and thus the
> > > currentLevel->key() had to crash. It should be fixed now.
> > > Please check the frameworks branch again (also look at the last
> > > commit in case I got all confused reading code during the
> > > daylight saving time transition ;)) ... no seriously. I get
> > > confused reading libkdegames code. Too complex for a few short
> > > evenings of trying here and there.
> > > 
> > > Thanks for the hints.
> > 
> > The crash seems gone here.
> 
> May I merge this to master then? Functionally it seems fine to me. I
> played both game types quite a few times, changed options and such.
> 
> Also I would like to see what EBN thinks of my attempts to get rid of
> its warnings. :)

If you think it's good and will help fixing any bugs that may show when 
released, sure.

Cheers,
  Albert

> 
> Regards
> Frederik
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel