[Kde-games-devel] Review Request 125578: Avoid the occurrence of invisible blocks. Fixes bugs #333694 and #344506

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125578/
-----------------------------------------------------------

(Updated Oct. 25, 2015, 2:21 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit 65a1b8136535758c77f66b505255206fd13f3117 by Julian Helfferich to branch master.


Bugs: 333694 and 344506
    http://bugs.kde.org/show_bug.cgi?id=333694
    http://bugs.kde.org/show_bug.cgi?id=344506


Repository: kblocks


Description
-------

When a full line is removed from the field the topmost line is not updated. This leads to the occurrence of "invisible blocks" filling the respective columns. The patch adds a loop filling the topmost line with empty cells.

The patch has been suggested by GJ in the discussion to bug #333694.


Diffs
-----

  KBlocksField.cpp bbb3ce2 

Diff: https://git.reviewboard.kde.org/r/125578/diff/


Testing
-------

* Filled a column up to the topmost line
* Removing several lines from the field (by filling them)
* Confirmed that the columns are accessible, i.e. that they are no longer filled with invisible blocks.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151025/b1550a88/attachment.html>