[Kde-games-devel] Review Request 125578: Avoid the occurrence of invisible blocks. Fixes bugs #333694 and #344506

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125578/#review87169
-----------------------------------------------------------


Hi,

as I do not have much experience with KDE development, I would highly appreciate to get some feedback. And if nobody objects, I will commit the bugfix at the end of this week.

Best regars,
Julian

- Julian Helfferich


On Oct. 10, 2015, 2:13 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125578/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2015, 2:13 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 333694 and 344506
>     http://bugs.kde.org/show_bug.cgi?id=333694
>     http://bugs.kde.org/show_bug.cgi?id=344506
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> When a full line is removed from the field the topmost line is not updated. This leads to the occurrence of "invisible blocks" filling the respective columns. The patch adds a loop filling the topmost line with empty cells.
> 
> The patch has been suggested by GJ in the discussion to bug #333694.
> 
> 
> Diffs
> -----
> 
>   KBlocksField.cpp bbb3ce2 
> 
> Diff: https://git.reviewboard.kde.org/r/125578/diff/
> 
> 
> Testing
> -------
> 
> * Filled a column up to the topmost line
> * Removing several lines from the field (by filling them)
> * Confirmed that the columns are accessible, i.e. that they are no longer filled with invisible blocks.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151021/cecba603/attachment.html>