[Kde-games-devel] Review Request 125498: Do not delete button box too early

[Frederik Schwarzer]

> On Oct. 5, 2015, 10:08 p.m., Albert Astals Cid wrote:
> > - pressing enter -> close button will be shown
> > 
> > Is it really shown for you? I get nothing
> 
> Frederik Schwarzer wrote:
>     Umm, yes. My changes make the new Close button appear. Tested in KShisen.
> 
> Albert Astals Cid wrote:
>     Hmmm, which style are you using?
> 
> Frederik Schwarzer wrote:
>     Breeze. Or do you mean some other kind of style? :)
> 
> Albert Astals Cid wrote:
>     I've tried with Breeze and also adding a show() after the add close button and still no button :/

So, after looking at the code again, there is still issues and the patch needs to be reworked. for me the buttons do change but the edit line remains active. I am currently looking into this but it might take some days since this is a busy weekend for me.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125498/#review86397
-----------------------------------------------------------


On Oct. 3, 2015, 2:12 a.m., Frederik Schwarzer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125498/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2015, 2:12 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> As discussed on the mailing list, the buttons just disappear when pressing Enter on the name input in kscoredialog. This was caused by a strange single-shot timer that led to the deletion of the button box.
> I also moved the creation of the Close button to the slot executed when the name input is confirmed, since in the other slots the button was created just before the dialog was closed due to the ::acept and ::reject actions.
> 
> Please comment since I lack experience. :)
> 
> 
> Diffs
> -----
> 
>   highscore/kscoredialog.cpp 5e50948 
> 
> Diff: https://git.reviewboard.kde.org/r/125498/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested dialog from kshisen by
> - pressing enter -> close button will be shown
> - clicking "forget" -> dialog closes
> - clicking "remember" -> dialog closes
> 
> 
> Thanks,
> 
> Frederik Schwarzer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151009/aeb46f2e/attachment.html>