[Kde-games-devel] Review Request 125508: Create application directory if it doesn't exist
Jeremy Whiting
jpwhiting at kde.org
Sat Oct 3 18:24:55 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125508/#review86306
-----------------------------------------------------------
Ship it!
Ship It!
- Jeremy Whiting
On Oct. 3, 2015, 11:28 a.m., Wolfgang Bauer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125508/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2015, 11:28 a.m.)
>
>
> Review request for KDE Games.
>
>
> Bugs: 350160
> http://bugs.kde.org/show_bug.cgi?id=350160
>
>
> Repository: kpat
>
>
> Description
> -------
>
> Unlike KStandardDirs, QStandardDirs doesn't guarantee that the returned directory actually exists, see also https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs .
>
> This patch checks for the existence of the directory and creates it if it isn't there, before the game state is saved.
>
>
> Diffs
> -----
>
> mainwindow.cpp e604a79
>
> Diff: https://git.reviewboard.kde.org/r/125508/diff/
>
>
> Testing
> -------
>
> - Delete ~/.local/share/kpat if it exists
> - Run kpat
> - Enable "Remember State on Exit" in the Settings menu
> - Select a game and play some moves
> - Quit kpat and start it again
>
> The game is correctly restored now.
>
>
> Thanks,
>
> Wolfgang Bauer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151003/e74b3611/attachment.html>
More information about the kde-games-devel
mailing list