[Kde-games-devel] KMahjongg frameworks branch

[Ian Wadham]

On 22/11/2015, at 11:40 PM, Frederik Schwarzer wrote:

> Am Sonntag, 22. November 2015, 14:21:21 schrieb Ian Wadham:
>> On 22/11/2015, at 6:52 AM, Frederik Schwarzer wrote:
>>> Am Samstag, 21. November 2015, 09:01:59 schrieb Ian Wadham:
> 
> Hi Ian,
> 
>> First off, how can I browse the central KDE Games repositories these
>> days?  I used to go to
>> https://projects.kde.org/projects/kde/kdegames/kmahjongg/repository/
>> but that is no longer kept up-to-date… :-(
> 
> Known problem for ... I think since April this year but no fix thus 
> far. You can use https://quickgit.kde.org/ ... though a bit messy to 
> browse some keywords due to all the private clones. For the games it's 
> alright though. Like https://quickgit.kde.org/?p=kmahjongg.git
> 
> There is also the gitk application. With "gitk --all ." you cann see 
> all branches of your local clone.

Thanks, Frederik.

>> Anyway, here is the patch…
> 
> The code in question has changed a bit in frameworks branch so I had 
> to adjust the patch.
> I did not like the "if this, then nothing, else, something" approach 
> before so I refactored-out the empty block. Now with your change, the 
> condition has become a bit more complex than feels good for me. So 
> please review and comment.

Looks good, at a glance, on quickgit, but I have not had time today to
look at it carefully.

> It might be better (meaning: more readable) 
> to have two nested if()-statements in this case.
> https://quickgit.kde.org/?p=kmahjongg.git&a=commitdiff&h=ae317c58b677a7f5edb0dffb1e5082397563a120

I'll have a closer look.  Also I need to commit the fix to remove KGameCanvas
usage from the KMahjongg editor, as discussed in my other emails.

> Thank you for the patch. It works good here. :)

That is good to hear… :-)

Cheers, Ian W.