[Kde-games-devel] KMahjongg frameworks branch

[Albert Astals Cid]

El Sunday 22 November 2015, a les 14:21:21, Ian Wadham va escriure:
> Hi Frederik,
> 
> First off, how can I browse the central KDE Games repositories these
> days?  I used to go to
> https://projects.kde.org/projects/kde/kdegames/kmahjongg/repository/
> but that is no longer kept up-to-date… :-(

http://quickgit.kde.org/

is what you want, or https://github.com/kde

Cheers,
  Albert

> 
> On 22/11/2015, at 6:52 AM, Frederik Schwarzer wrote:
> > Am Samstag, 21. November 2015, 09:01:59 schrieb Ian Wadham:
> >> On 20/11/2015, at 10:05 PM, Frederik Schwarzer wrote:
> >> It goes into an endless loop, trying to find a default layout and
> >> background. It succeeds with the layout, but not with the
> >> background.  Then it tries both the layout and the background
> >> again… and again…
> > 
> > Yes, that's what I can see here as well. Thanks for confirming.
> > I will leave my hands off of this. If you need testing or something,
> > please speak up.
> 
> I have found the problem, fixed it and tested the fix on my _local_
> qgraphic branch.  The problem was due to an endless recursion
> (or re-entry) in KMahjongg::loadSettings().  It was treating an empty
> setting for the layout-file path as a new layout, because the default
> setting was not yet saved, so it called startNewGame() for the "new
> layout" and it immediately called back to loadSettings()…
> 
> My patch is attached.  And here is my comment for the commit:
> 
>     Avoid an endless recursion when there is no saved layout setting.
> 
> I have not been able to push this commit to the central qgraphic
> branch because there is a clash and I cannot see what is going on
> (see my question at the start of this post).  The clash involves the
> files boardwidget.cpp and (indirectly) boardwidget.h.
> 
> Those files are supposed to have been deleted.  They are superseded
> by the new QGraphisView code, I seem to remember…
> 
> Anyway, here is the patch…
> 
> Cheers, Ian W.