[Kde-games-devel] KMahjongg frameworks branch

[Frederik Schwarzer]

Am Freitag, 20. November 2015, 04:19:07 schrieb Roney Gomes:
> 2015-11-16 23:47 GMT-03:00 Ian Wadham <iandw.au at gmail.com>:
> > Note that (in the "Mahjongg archaeology" thread), Roney reported a
> > successful merge of qgraphic to frameworks, with no difficulties. 
> > So I think it is safe for you to try step c, Frederik.
> 
> In order to make the history tree as linear and clean as possible I
> decided to rebase the qgraphics branch atop the frameworks one,
> since the frameworks port would affect less the old game canvas
> code.
> 
> Had to solve some minor conflicts here and there but the whole
> process went smoother than expected. It only remained to apply Jean
> Peter's last patches but for some reason I got discouraged and
> didn't continue. I don't remember the reason today, but I think it
> was because the rebasing idea turned out to be not that popular and
> someone else was already working on the same thing, IIRC.

Do not be discouraged by other people having a different opinion. I 
know that many people object rebasing of branches. Not sure what the 
reasoning is there but different people, different opinions.

Several people working on the same issue in parallel is discouraging, 
though.

If you would like to help with KMahjongg porting, say so. It's in the 
frameworks branch and needs testing. Also I did not habe the time to 
check if all the bugfixes Ian mentioned are present in that current 
version.

Regards
Frederik