[Kde-games-devel] Review Request 126040: Check that the undo stack and the moves list are not empty before the undo operation.

[Laurent Montel]

> On nov. 14, 2015, 3:07 après-midi, Laurent Montel wrote:
> > src/game/game.cpp, line 458
> > <https://git.reviewboard.kde.org/r/126040/diff/1/?file=416631#file416631line458>
> >
> >     you make test before no ? Why readd it here ?
> 
> Arseny Krasutsky wrote:
>     Just an excess check.

so not necessary as it will away true :)


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126040/#review88347
-----------------------------------------------------------


On nov. 12, 2015, 7:34 matin, Arseny Krasutsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126040/
> -----------------------------------------------------------
> 
> (Updated nov. 12, 2015, 7:34 matin)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 266871
>     http://bugs.kde.org/show_bug.cgi?id=266871
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Check that the undo stack and the moves list are not empty before the undo operation. Fixes https://bugs.kde.org/show_bug.cgi?id=266871
> 
> 
> Diffs
> -----
> 
>   src/game/game.cpp 3877cd2 
> 
> Diff: https://git.reviewboard.kde.org/r/126040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arseny Krasutsky
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151117/d88fa80c/attachment.html>