[Kde-games-devel] Review Request 122211: [libkdegames] Make tests optional

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122211/#review88240
-----------------------------------------------------------


Hi,

sorry for having this review sitting here for so long. kdegames is quite understaffed.

Can you please check if this is still needed? The cmake files have changed since when you opened this review.

Thank you.

- Frederik Schwarzer


On Feb. 7, 2015, 6:49 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122211/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2015, 6:49 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Qt5Test should not be mandatory, ~~patch to add tests subdirs only if BUILD_TESTING and moved find_package(Qt5Test...) into the respective tests CMakeLists.txt~~
> 
> I should add that I don't have write access, so I ask for someone else to merge it.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2664fd4ea3234bfe6f9c7d4062579e91adc163fe 
> 
> Diff: https://git.reviewboard.kde.org/r/122211/diff/
> 
> 
> Testing
> -------
> 
> Built with and without tests.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151111/ab0eb540/attachment.html>