[Kde-games-devel] Review Request 125992: fix homepage link: Insert empty otherText in KAboutData constructor

Jakob Gruber jakob.gruber at gmail.com
Wed Nov 11 08:26:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125992/#review88239
-----------------------------------------------------------

Ship it!


Ship It!

- Jakob Gruber


On Nov. 8, 2015, 1:33 a.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125992/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 1:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: picmi
> 
> 
> Description
> -------
> 
> The hyperlink in >Help >About Picmi does not work, because the hyperlink
> is put in the place of the additional free form text for that dialog.
> 
> This was probably an accident in commit 7ab84ae5b3a... when porting to
> KF5. Fix it by inserting a QString().
> 
> 
> Diffs
> -----
> 
>   src/main.cpp ec3c5f259bfa4b2e76b3f14231ce79eebd1b7fae 
> 
> Diff: https://git.reviewboard.kde.org/r/125992/diff/
> 
> 
> Testing
> -------
> 
> Compiling, Running. Clicking on the hyperlink.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151111/8f1ce531/attachment.html>


More information about the kde-games-devel mailing list