[Kde-games-devel] Review Request 125992: fix homepage link: Insert empty otherText in KAboutData constructor

[Jakob Gruber]

Sorry for the late reply, only just noticed this. I also prefer Frederik's
version, but either way looks good to me.

Thanks for the patch!
Jakob

On Wed, Nov 11, 2015 at 9:19 AM, Frederik Schwarzer <schwarzer at kde.org>
wrote:

> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125992/
>
> On November 8th, 2015, 2:13 a.m. UTC, *Frederik Schwarzer* wrote:
>
> src/main.cpp
> <https://git.reviewboard.kde.org/r/125992/diff/1/?file=415723#file415723line50> (Diff
> revision 1)
>
> int main(int argc, char *argv[])
>
> 49
>
>                       "https://projects.kde.org/projects/kde/kdegames/picmi");
>
> 50
>
>                       "https://projects.kde.org/projects/kde/kdegames/picmi");
>
> I know, not directly related to your change, but maybe Jakob can answer, why the link goes projects.kde.org, while there is something more colourful like https://games.kde.org/picmi ? :)
>
> Other than that, your fix is valid. ... ... although :D
>
> It might be more readable to give the constructor only everything until the copyright info and then use .setHomepage() to set the URL.
>
> Here the (simplified) code from KShisen:
>
> KAboutData aboutData(QStringLiteral("kshisen"), i18n("Shisen-Sho"),
> QStringLiteral(KSHISEN_VERSION),
> i18n(description), KAboutLicense::GPL,
> i18n("(c)"));
>
> aboutData.setHomepage(QStringLiteral("http://games.kde.org/kshisen"));
>
> Since Jakob does notr seem to read this, can you please try to reach him directly?
>
> As for the link fix change, please commit it. Either in your version or mine, whatever feels better to you.
>
>
> - Frederik
>
> On November 8th, 2015, 1:33 a.m. UTC, Martin Walch wrote:
> Review request for KDE Games.
> By Martin Walch.
>
> *Updated Nov. 8, 2015, 1:33 a.m.*
> *Repository: * picmi
> Description
>
> The hyperlink in >Help >About Picmi does not work, because the hyperlink
> is put in the place of the additional free form text for that dialog.
>
> This was probably an accident in commit 7ab84ae5b3a... when porting to
> KF5. Fix it by inserting a QString().
>
> Testing
>
> Compiling, Running. Clicking on the hyperlink.
>
> Diffs
>
>    - src/main.cpp (ec3c5f259bfa4b2e76b3f14231ce79eebd1b7fae)
>
> View Diff <https://git.reviewboard.kde.org/r/125992/diff/>
>
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151111/23d7d431/attachment-0001.html>