[Kde-games-devel] Review Request 125992: fix homepage link: Insert empty otherText in KAboutData constructor

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125992/#review88150
-----------------------------------------------------------



src/main.cpp (line 50)
<https://git.reviewboard.kde.org/r/125992/#comment60465>

    I know, not directly related to your change, but maybe Jakob can answer, why the link goes projects.kde.org, while there is something more colourful like https://games.kde.org/picmi ? :)
    
    Other than that, your fix is valid. ... ... although :D
    
    It might be more readable to give the constructor only everything until the copyright info and then use .setHomepage() to set the URL.
    
    Here the (simplified) code from KShisen:
    
    ```c++
    KAboutData aboutData(QStringLiteral("kshisen"), i18n("Shisen-Sho"),
    QStringLiteral(KSHISEN_VERSION),
    i18n(description), KAboutLicense::GPL,
    i18n("(c)"));
    
    aboutData.setHomepage(QStringLiteral("http://games.kde.org/kshisen"));
    ```


- Frederik Schwarzer


On Nov. 8, 2015, 1:33 a.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125992/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2015, 1:33 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: picmi
> 
> 
> Description
> -------
> 
> The hyperlink in >Help >About Picmi does not work, because the hyperlink
> is put in the place of the additional free form text for that dialog.
> 
> This was probably an accident in commit 7ab84ae5b3a... when porting to
> KF5. Fix it by inserting a QString().
> 
> 
> Diffs
> -----
> 
>   src/main.cpp ec3c5f259bfa4b2e76b3f14231ce79eebd1b7fae 
> 
> Diff: https://git.reviewboard.kde.org/r/125992/diff/
> 
> 
> Testing
> -------
> 
> Compiling, Running. Clicking on the hyperlink.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151108/1220982a/attachment.html>