[Kde-games-devel] Review Request 125955: Remove unused dependencies in kdiamond

Michael Palimaka kensington at gentoo.org
Thu Nov 5 16:06:36 UTC 2015



> On Nov. 5, 2015, 3:29 p.m., Laurent Montel wrote:
> > CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/125955/diff/1/?file=415464#file415464line18>
> >
> >     icontheme ? are you sure ?

I see QIcon being used, but nothing from KIcon*


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125955/#review88054
-----------------------------------------------------------


On Nov. 5, 2015, 1:03 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125955/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 1:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kdiamond
> 
> 
> Description
> -------
> 
> These dependencies seem unused, so remove them.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ea29bca7742301dcad3fa095f3b3bf7505362d6b 
> 
> Diff: https://git.reviewboard.kde.org/r/125955/diff/
> 
> 
> Testing
> -------
> 
> Inspected source, builds, runs.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151105/1b203ab8/attachment.html>


More information about the kde-games-devel mailing list