[Kde-games-devel] Review Request 125906: Fix lots of warnings (gcc and krazy), API doc fixes, cleanup includes ...

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125906/#review88025
-----------------------------------------------------------

Ship it!


Ship It!

- Albert Astals Cid


On nov. 4, 2015, 12:45 a.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125906/
> -----------------------------------------------------------
> 
> (Updated nov. 4, 2015, 12:45 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> Fix warnings:
> 
> * explicit constructors
> * naming convention of include guards
> * allocate dialogs on heap and hold in QPointer
> * add newline at EOF
> 
> Update website in README, main.cpp, and lskat.lsm
> 
> Fix some issues in API documentation
> 
> Fix some spelling errors in strings
> 
> Clean up includes, in particular remove unused includes
> 
> 
> Diffs
> -----
> 
>   README d6131309dfd7d2dc6bd60dad15c089d51c6184c0 
>   lskat.lsm bd90d94eb9a38625ee9de2c5bd5c95ccec4c29a6 
>   src/abstractengine.h e6aae39027ca6c6ca917f53881d80780f1d6a23f 
>   src/abstractinput.h d1d831ad0455ffa90bb805d1e18477bb205f0cbd 
>   src/aiinput.h a9aac3a2bd54e3ee3a493ecdc48d3678f20b94c8 
>   src/cardsprite.h 074fab9abbbaf7312f916b7606e052753b4d2514 
>   src/cardsprite.cpp a2e23c66344206861f0527985f9bffa5e9a99b2d 
>   src/config-src.h.cmake 2375fd30d6de1ab735a4c1ad94774ccf403d7339 
>   src/config_two.h 7e7b256a1ff580dd9c9948dceeb28310e3d3867c 
>   src/deck.h 68a1d927315b127c7f3bfaf15278dd5c7b09fc17 
>   src/display_intro.cpp 027822d694e9b4f1a7b4cfefe7eef7d01835390c 
>   src/fromlibkdegames/cardcache.h 8d5f99e7c0983bd7da510b4c2e0e16d60df67cd6 
>   src/fromlibkdegames/cardcache.cpp ec6e78c0fd521722e66b44a76514302493b7f861 
>   src/fromlibkdegames/cardcache_p.h effd6180c5104af6276e6e8e84e43dfac11b0be4 
>   src/fromlibkdegames/carddeckinfo.h 57cd7b530e7192e9b016539b83098e491437da2d 
>   src/fromlibkdegames/carddeckinfo_p.h 70df1bffe3b32ff4cf772ee5f22731bef27a22c4 
>   src/fromlibkdegames/kcarddialog.h 040fd9d8a59f22890207b6a1b64778edc663d8e0 
>   src/fromlibkdegames/kcarddialog.cpp 84602e29f075a7a85c417227cdadd0f47a3a5170 
>   src/gameview.h d052b010f267ef9ba9896b62cb19fc1038cd823d 
>   src/gameview.cpp 11fc524d83cbfe40a580fcb63d27c4db19c8a655 
>   src/main.cpp 51afdc7b6bfa00bda81dc7bfe3416570c02ce756 
>   src/mainwindow.h e516498b27be7fb2041da4c0db43edfdf111fd72 
>   src/mainwindow.cpp 82a11ca6d4e29396b74d2927faa717d9aa4a8e8b 
>   src/mouseinput.h 3c15cc3c452963a186f5e0a5dbc3663d743e1fbd 
>   src/namedialogwidget.h 9a05f0e25ec424fe7a7ba3c79405e766ce2d59c7 
>   src/pixmapsprite.h 979fd8b923452be0bbb649e4ebd761da8957779c 
>   src/pixmapsprite.cpp ee0e09f182eb48808b328915f0f1ace2f7ff8f15 
>   src/scoresprite.h b14fdc90223d895df3389a6c859578009688bbbc 
>   src/scoresprite.cpp 2b0be3136bb5c2abfd857d36bd47c54778826388 
>   src/textsprite.h 15cf431fd2aec239a31a9bc261900dd8a913afbd 
>   src/thememanager.cpp 74caf04f7ee6c0a9383fcfbacb41bb57f472eee4 
> 
> Diff: https://git.reviewboard.kde.org/r/125906/diff/
> 
> 
> Testing
> -------
> 
> Compiled on KF5.
> Started and played some rounds, no obvious downsides encountered.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151104/b4d34387/attachment-0001.html>