[Kde-games-devel] Review Request 125906: Fix lots of warnings (gcc and krazy), spelling errors, documentation, ...

[Frederik Schwarzer]

> On Nov. 1, 2015, 8:52 p.m., Frederik Schwarzer wrote:
> > Could you please try to separate whitespace changes in a separate commit? You do not have to post that to reviewboard then. It is just painfully hard to find real changes in a commit of 90% whitespace changes. :)
> 
> Martin Walch wrote:
>     Alright. What about spelling errors, documentation fixes etc?

In general I think it's good that they will be fixed (so I do for the whitespaces). :)
I am just not sure I spotted all the real changes in those two-page diff.

If you tested your changes properly, I do not see a problem with your changes.


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125906/#review87817
-----------------------------------------------------------


On Nov. 1, 2015, 9:56 a.m., Martin Walch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125906/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 9:56 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: lskat
> 
> 
> Description
> -------
> 
> Fix warnings:
> 
> * explicit constructors
> * use KLineEdit instead of QLineEdit
> * naming convention of include guards
> * allocate dialogs on the heap and hold them in QPointers
> * add newline at EOF
> 
> Update website in README and main.cpp
> 
> Clean up lskat.lsm
> 
> Fix lots of typos
> 
> Fix some issues in API documentation
> 
> Clean up some whitespace
> 
> Most obvious changes are probably the updated URL in >Help >About LSkat and the use of KLineEdit instead of QLineEdit in the dialog for changing the player names.
> 
> 
> Diffs
> -----
> 
>   README d6131309dfd7d2dc6bd60dad15c089d51c6184c0 
>   lskat.lsm bd90d94eb9a38625ee9de2c5bd5c95ccec4c29a6 
>   src/abstractdisplay.h 5c25f9e1dc0391c0863619c6819d641911f073ee 
>   src/abstractdisplay.cpp e8a8f1266af1ce20be6ad5de931b1cdce037c9bf 
>   src/abstractengine.h e6aae39027ca6c6ca917f53881d80780f1d6a23f 
>   src/abstractengine.cpp 7abc3ca665014394f1f3694231085b310bf6f751 
>   src/abstractinput.h d1d831ad0455ffa90bb805d1e18477bb205f0cbd 
>   src/abstractinput.cpp 53df16db5bc84fce5dbfc0a7f474f69963ea8e84 
>   src/aiinput.h a9aac3a2bd54e3ee3a493ecdc48d3678f20b94c8 
>   src/aiinput.cpp e8d6865026a8ef94041b44d92717b3f882b2c96a 
>   src/cardsprite.h 074fab9abbbaf7312f916b7606e052753b4d2514 
>   src/cardsprite.cpp a2e23c66344206861f0527985f9bffa5e9a99b2d 
>   src/config-src.h.cmake 2375fd30d6de1ab735a4c1ad94774ccf403d7339 
>   src/config_two.h 7e7b256a1ff580dd9c9948dceeb28310e3d3867c 
>   src/config_two.cpp 6ed225a62b93c6c1f55f0489feae2bcb85877935 
>   src/deck.h 68a1d927315b127c7f3bfaf15278dd5c7b09fc17 
>   src/deck.cpp 9af9ff570c8347d910ca78e3942fec9259b93f09 
>   src/display_intro.h 45d93a61b4d29452036c4a0e7d798043719854f7 
>   src/engine_two.h aba52c01142cd2d4995fdc6162872a9ed2b8e3c2 
>   src/engine_two.cpp 579e23a6d48d7496e06667b13564276de11f3cb1 
>   src/fromlibkdegames/cardcache.h 8d5f99e7c0983bd7da510b4c2e0e16d60df67cd6 
>   src/fromlibkdegames/cardcache.cpp ec6e78c0fd521722e66b44a76514302493b7f861 
>   src/fromlibkdegames/cardcache_p.h effd6180c5104af6276e6e8e84e43dfac11b0be4 
>   src/fromlibkdegames/carddeckinfo.h 57cd7b530e7192e9b016539b83098e491437da2d 
>   src/fromlibkdegames/carddeckinfo.cpp d9e584b19ee5c8e93341d56b3398c722544810ef 
>   src/fromlibkdegames/carddeckinfo_p.h 70df1bffe3b32ff4cf772ee5f22731bef27a22c4 
>   src/fromlibkdegames/kcarddialog.h 040fd9d8a59f22890207b6a1b64778edc663d8e0 
>   src/gameview.h d052b010f267ef9ba9896b62cb19fc1038cd823d 
>   src/gameview.cpp 11fc524d83cbfe40a580fcb63d27c4db19c8a655 
>   src/lskatglobal.h 0c06da022a1053d1b55e7aa652cf1480a53676fc 
>   src/lskatui.rc 4132ff86c4b823405ecbe903ed51d060a1fed7a9 
>   src/main.cpp 51afdc7b6bfa00bda81dc7bfe3416570c02ce756 
>   src/mainwindow.h e516498b27be7fb2041da4c0db43edfdf111fd72 
>   src/mainwindow.cpp 82a11ca6d4e29396b74d2927faa717d9aa4a8e8b 
>   src/mouseinput.h 3c15cc3c452963a186f5e0a5dbc3663d743e1fbd 
>   src/mouseinput.cpp 70988a6ab163ae3498dd3e44088fb6f62375a653 
>   src/namedialog.ui 681d76c896572c6973645d89104647ea7a0847c1 
>   src/namedialogwidget.h 9a05f0e25ec424fe7a7ba3c79405e766ce2d59c7 
>   src/pixmapsprite.h 979fd8b923452be0bbb649e4ebd761da8957779c 
>   src/pixmapsprite.cpp ee0e09f182eb48808b328915f0f1ace2f7ff8f15 
>   src/player.cpp f34f6d74b6a066b2553e9c816bab8600c337be5d 
>   src/scoresprite.h b14fdc90223d895df3389a6c859578009688bbbc 
>   src/scoresprite.cpp 2b0be3136bb5c2abfd857d36bd47c54778826388 
>   src/textsprite.h 15cf431fd2aec239a31a9bc261900dd8a913afbd 
>   src/textsprite.cpp 55d981906b6bdcb0e0845891e89553ae77ca1526 
>   src/thememanager.cpp 74caf04f7ee6c0a9383fcfbacb41bb57f472eee4 
> 
> Diff: https://git.reviewboard.kde.org/r/125906/diff/
> 
> 
> Testing
> -------
> 
> Compiled on KF5.
> Started and played some rounds, no obvious downsides encountered.
> 
> 
> Thanks,
> 
> Martin Walch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20151101/b5b4e4d7/attachment-0001.html>