[Kde-games-devel] Review Request 125906: Fix lots of warnings (gcc and krazy), spelling errors, documentation, ...

[Frederik Schwarzer]

On Sunday, 1. November 2015 21:33:55 you wrote:
> > On Nov. 1, 2015, 8:40 nachm., Laurent Montel wrote:
> > > src/namedialog.ui, line 35
> > > <https://git.reviewboard.kde.org/r/125906/diff/1/?file=413928#fi
> > > le413928line35>> > 
> > >     why ?
> > >     We try to use QLineEdit unless there is a missing feature.
> > >     So what is the missing feature here ?
> > 
> > Frederik Schwarzer wrote:
> >     Just for reference:
> >     https://community.kde.org/Frameworks/Porting_Notes#General_2
> >     Second bullet point.
> > 
> > Laurent Montel wrote:
> >     Ok but as I reformulate my question. Why now it's necessary ?
> >     Ok I know that klineedit support completion but why now it
> >     needs it ?
> The only real reason for the change is the fact that krazy complains
> about using QLineEdit ("... make sure to use the KDE version of
> some Qt GUI elements to provide a consistent look and feel for the
> KDE desktop.")
> 
> If this is against KDE policies, krazy probably needs some
> adjustment.

Yep. That's the perks of bigger transitions.
Could you please file a ticket?
https://bugs.kde.org/describecomponents.cgi?product=krazy