[Kde-games-devel] i18n issues in kf5 kdegames

[laurent Montel]

Le Thursday 28 May 2015 14:35:04 Burkhard Lück a écrit :
> Hi,

Hi,

> the kdegames in kf5 have some untranslated strings in the GUI.
> Try e.g. KPat in a locale !=en_US and you will see the untranslated string
> "Move" in the menu.
> 
> The string "Move" is in the KXmlGui (.rc) file kpatui.rc and extracted to
> the catalog KPat, but there is only a query for the translation of "Move"
> with the wrong domain "kxmlgui5".
> 
> Reason for that is the usage of
> add_definitions(-DTRANSLATION_DOMAIN="kpat") in CMakeLists.txt
> instead of
> KLocalizedString::setApplicationDomain("kpat"); in a .cpp file
> for applications.

Ah yes indeed .

> See also
> http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.
> html
> 
> Attached a patch to fix this issue for KPat, but nearly all games are
> affected:

Thanks.
I started to fix all kdegames.

Thanks for info.

Regards

> ~/src/kdegames$ wcgrep TRANSLATION_DOMAIN
> ./kbreakout/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="kbreakou
> t")
> ./kblackbox/CMakeLists.txt:31:add_definitions(-DTRANSLATION_DOMAIN="kblackb
> ox")
> ./katomic/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="katomic")
> ./granatier/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="granati
> er")
> ./kshisen/CMakeLists.txt:31:add_definitions(-DTRANSLATION_DOMAIN="kshisen")
> ./bomber/CMakeLists.txt:32:add_definitions(-DTRANSLATION_DOMAIN="bomber")
> ./kapman/CMakeLists.txt:35:add_definitions(-DTRANSLATION_DOMAIN="kapman")
> ./kjumpingcube/CMakeLists.txt:38:add_definitions(-
> DTRANSLATION_DOMAIN="kjumpingcube")
> ./kbounce/CMakeLists.txt:37:add_definitions(-DTRANSLATION_DOMAIN="kbounce")
> ./kfourinline/CMakeLists.txt:38:add_definitions(-
> DTRANSLATION_DOMAIN="kfourinline")
> ./ksquares/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="ksquares"
> )
> ./kblocks/CMakeLists.txt:40:add_definitions(-DTRANSLATION_DOMAIN="kblocks")
> ./kdiamond/CMakeLists.txt:32:add_definitions(-DTRANSLATION_DOMAIN="kdiamond
> ")
> ./killbots/CMakeLists.txt:37:add_definitions(-DTRANSLATION_DOMAIN="killbots
> ")
> ./kollision/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="kollisi
> on")
> ./klines/CMakeLists.txt:36:add_definitions(-DTRANSLATION_DOMAIN="klines")
> 
> Oh and kmines does not load its translation catalog "kmines" not at all

-- 
Laurent Montel | laurent.montel at kdab.com | KDE/Qt Senior Software Engineer
KDAB (France) S.A.S., a KDAB Group company
Tel. France +33 (0)4 90 84 08 53,  http://www.kdab.fr