[Kde-games-devel] Data migration issue

David Faure faure at kde.org
Sun Mar 22 17:19:46 UTC 2015


On Saturday 21 March 2015 23:53:07 Albert Astals Cid wrote:
> Too late for KDE Applications 15.04 though now that i think, so maybe we 
> actually have to suggest everybody using the migrator to add those extra 
> lines?

OK, that means:

--- a/src/lib/util/kdelibs4configmigrator.h
+++ b/src/lib/util/kdelibs4configmigrator.h
@@ -60,6 +60,10 @@ public:
      *    look for old data to migrate as well
      * }
      * @endcode
+     *
+     * IMPORTANT: after migrate() returns true, call KSharedConfig::openConfig()->reparseConfiguration()
+     * so that the global config (very likely already created by e.g. the platform integration plugin)
+     * can see the migrated data.
      */
     bool migrate();
 
But wait, this makes me realize another solution: kdelibs4configmigrator could load the
framework integration plugin, which would take care of this, if installed.

Patch attached. Tested, at least to the extent that the slot is indeed being called.

Obviously that's still "too late for KDE Applications 15.04", so maybe fix the apps that you want to see fixed
for 15.04 with a
#if KCOREADDONS_VERSION < 0x050900
KSharedConfig::openConfig()->reparseConfiguration();
#endif

and KF 5.9 will make this unnecessary, i.e. the doc change won't get committed.

Any input?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kcoreaddons.diff
Type: text/x-patch
Size: 794 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150322/d57486f4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: frameworkintegration.diff
Type: text/x-patch
Size: 1216 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150322/d57486f4/attachment-0001.bin>


More information about the kde-games-devel mailing list