[Kde-games-devel] Data migration issue

[David Faure]

On Saturday 21 March 2015 19:18:53 laurent Montel wrote:
> Le Saturday 21 March 2015 17:05:06 Albert Astals Cid a écrit :
> > El Dissabte, 21 de març de 2015, a les 11:38:14, Matthew Dawson va 
escriure:
> > > On March 21, 2015 04:29:25 PM Mathias Kraus wrote:
> > > > Am Samstag, 21. März 2015, 11:06:02 schrieb Matthew Dawson:
> > > > > On March 21, 2015 04:00:11 PM Mathias Kraus wrote:
> > > > > > =======
> > > > > > KConfig config(QLatin1String("kminesrc"));
> > > > > > config.reparseConfiguration();
> > > > > > =======
> > > > > 
> > > > > Sorry, my suggestion of using reparseConfiguration wasn't clear.  I
> > > > > meant
> > > > > using it against the global KSharedConfig, not a newly created
> > > > > KConfig.
> > > > > Instead, try:
> > > > > 
> > > > > KSharedConfig::openConfig()->reparseConfiguration();
> > > > > 
> > > > > And see if that helps (untested here).
> > > > 
> > > > Yes, that works. Should have told you what I tried.
> > > 
> > > Excellent!  So now we at least know what the problem is.
> > > 
> > > > Thanks very much. Now we need to update all kf5 games. I will do it
> > > > for
> > > > granatier but don't know if I have enough time to do it for all games.
> > > > Will
> > > > try to do it though.
> > > > 
> > > > Could this also be necessary for non-game applications?
> > > 
> > > I don't think this can be solved universally, as KConfig and KCoreAddons
> > > can't depend upon each other.  My only thought would be to have
> > > KCoreAddons
> > > lookup a symbol at runtime, and call that to reload all cached
> > > KSharedConfigs, but I have no idea if that is feasible, never mind if it
> > > will work.  Failing that, we should update the documentation to mention
> > > the
> > > need to reload any KSharedConfigs after migration.
> > > 
> > > Thoughts?
> > 
> > Why is Kdelibs4ConfigMigrator in kcoreaddons and not in kconfig?
> 
> Because it use Kdelibs4Migration which is in kcoreaddons from beginning.

And basically because we didn't see that problem coming (the code doesn't 
actually use KConfig).

But yeah that would be a solution, making a new class in kconfig and 
deprecating the one in kcoreaddons.....

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5