[Kde-games-devel] Review Request 122963: [ksirk frameworks] Replace KDialog with QDialog.

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122963/#review77499
-----------------------------------------------------------



ksirk/Dialogs/InvasionSlider.cpp
<https://git.reviewboard.kde.org/r/122963/#comment53218>

    add accept() in slideClose and remove this second slot.



ksirk/Dialogs/InvasionSlider.cpp
<https://git.reviewboard.kde.org/r/122963/#comment53219>

    add reject() in slideCancel directly and remove second slot



ksirk/Dialogs/InvasionSlider.cpp
<https://git.reviewboard.kde.org/r/122963/#comment53220>

    Remove it


- Laurent Montel


On mars 14, 2015, 11:02 après-midi, Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122963/
> -----------------------------------------------------------
> 
> (Updated mars 14, 2015, 11:02 après-midi)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksirk
> 
> 
> Description
> -------
> 
> Using QDialog instead deprecated KDialog in frameworks branch
> 
> 
> Diffs
> -----
> 
>   ksirk/Dialogs/InvasionSlider.h 11646e3 
>   ksirk/Dialogs/InvasionSlider.cpp f15dfbd 
>   ksirk/kgamewin.h 61af3ee 
>   ksirk/kgamewin.cpp a86d344 
>   ksirkskineditor/mainwindow.h 22f1b5c 
>   ksirkskineditor/mainwindow.cpp 65c199e 
> 
> Diff: https://git.reviewboard.kde.org/r/122963/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150315/eb442243/attachment-0001.html>