[Kde-games-devel] Review Request 124178: Attempt to remove KDELibs4Support

[Jakob Gruber]

> On June 26, 2015, 5:29 a.m., Laurent Montel wrote:
> > CMakeLists.txt, line 22
> > <https://git.reviewboard.kde.org/r/124178/diff/1/?file=381352#file381352line22>
> >
> >     So add KIO if it can't find kiowidget

Probably necessary, yes. But I was mostly curious about where the link errors come from, since KIOWidgets and KDELibs4Support are not mentioned anywhere in the build files. Note also that the errors refer to libs that cannot exist (-lKF5::KIOWidgets).


> On June 26, 2015, 5:29 a.m., Laurent Montel wrote:
> > src/gui/selectboardwindow.cpp, line 22
> > <https://git.reviewboard.kde.org/r/124178/diff/1/?file=381356#file381356line22>
> >
> >     Why ?:)

jpwhiting helped resolve both this and below by adding KF5::I18n to link targets (it cannot find KLocalizedString without it).


- Jakob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124178/#review81766
-----------------------------------------------------------


On June 25, 2015, 1:27 p.m., Jakob Gruber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124178/
> -----------------------------------------------------------
> 
> (Updated June 25, 2015, 1:27 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: picmi
> 
> 
> Description
> -------
> 
> This results in errors at compile time:
> 
> /usr/bin/ld: cannot find -lKF5::KIOWidgets
> /usr/bin/ld: cannot find -lKF5::KDELibs4Support
> /usr/bin/ld: cannot find -lKF5::KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c9c31e4a14ec63e55c3da8aedd6df325c676d1fc 
>   src/CMakeLists.txt a2fdd59780deafd5fa42c8095ba419ed8ee4f034 
>   src/gui/CMakeLists.txt 43d75ed1633cfb7b5b4b23ed7ffa187e0c45062d 
>   src/gui/graphicsitems/pixmapitem.cpp c455073d8457fef6b4de855a4c950c98bbd49f29 
>   src/gui/selectboardwindow.cpp 44f89ee612275a934a9153cb37f1346d35bb5792 
>   src/logic/CMakeLists.txt 0433665c06fea2c7c59b9908250ab7415b9274da 
>   src/logic/levelloader.cpp 2abad5e3e7e26b7a5e3adb34bf7ef0ab0f878ae8 
>   src/main.cpp 943854f810eeef9483684a7f597fa9186aeafe3e 
>   test/logic/CMakeLists.txt 7dce7e71edd35e47ba8706a2fc44b0756857c52f 
> 
> Diff: https://git.reviewboard.kde.org/r/124178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jakob Gruber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150626/8c24ba1d/attachment.html>