[Kde-games-devel] Review Request 124178: Attempt to remove KDELibs4Support

[Jeremy Whiting]

> On July 12, 2015, 8:30 a.m., Albert Astals Cid wrote:
> > What's the status of this? Do you need help?

It builds and runs ok with this patch on my machine. Doesn't even build for Jakob. We've no idea why. It seems that libkdegames is pulling in libkde4support, though why it bulids for me is a mystery. Does it build for anyone else with this patch applied ?


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124178/#review82388
-----------------------------------------------------------


On June 30, 2015, 8:38 a.m., Jakob Gruber wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124178/
> -----------------------------------------------------------
> 
> (Updated June 30, 2015, 8:38 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: picmi
> 
> 
> Description
> -------
> 
> This results in errors at compile time:
> 
> /usr/bin/ld: cannot find -lKF5::KIOWidgets
> /usr/bin/ld: cannot find -lKF5::KDELibs4Support
> /usr/bin/ld: cannot find -lKF5::KDELibs4Support
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c9c31e4a14ec63e55c3da8aedd6df325c676d1fc 
>   src/CMakeLists.txt a2fdd59780deafd5fa42c8095ba419ed8ee4f034 
>   src/gui/CMakeLists.txt 43d75ed1633cfb7b5b4b23ed7ffa187e0c45062d 
>   src/gui/graphicsitems/pixmapitem.cpp c455073d8457fef6b4de855a4c950c98bbd49f29 
>   src/gui/graphicsitems/textbanneritem.cpp f9c56d642bfacfd52ccd8efb0f38b6d8986a8020 
>   src/gui/mainwindow.cpp 1821fca9afa2344a6927a6c6e4681e792a10a8ec 
>   src/gui/selectboardwindow.cpp 44f89ee612275a934a9153cb37f1346d35bb5792 
>   src/gui/settingswindow.cpp dd838c86f6a83fa39cfcd8f8d6bb0e02c2ca65d6 
>   src/logic/CMakeLists.txt 0433665c06fea2c7c59b9908250ab7415b9274da 
>   src/logic/levelloader.cpp 2abad5e3e7e26b7a5e3adb34bf7ef0ab0f878ae8 
>   src/main.cpp 943854f810eeef9483684a7f597fa9186aeafe3e 
>   test/logic/CMakeLists.txt 7dce7e71edd35e47ba8706a2fc44b0756857c52f 
>   test/logic/streaks_test.cpp 3281c40c68f20f5295567a2c511ecd76caf0d6fd 
> 
> Diff: https://git.reviewboard.kde.org/r/124178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jakob Gruber
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150712/568a15ae/attachment.html>