[Kde-games-devel] Review Request 121816: Reduce redrawing of game board

Albert Astals Cid aacid at kde.org
Sun Jul 12 14:30:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121816/#review82389
-----------------------------------------------------------


Anyone remembers what's the status of this? I remember we had some discussion on the mailing list and then it died?

- Albert Astals Cid


On jul. 12, 2015, 2:30 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121816/
> -----------------------------------------------------------
> 
> (Updated jul. 12, 2015, 2:30 p.m.)
> 
> 
> Review request for KDE Games and Ian Wadham.
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> Do not redraw the entire game board including background unless
> required due to a change of background or resize of the window.
> 
> 
> Diffs
> -----
> 
>   boardwidget.h 6e1d3f5 
>   boardwidget.cpp 6a4f033 
>   kmahjongg.h 3a101fc 
>   kmahjongg.cpp eb1dfa1 
> 
> Diff: https://git.reviewboard.kde.org/r/121816/diff/
> 
> 
> Testing
> -------
> 
> - Shuffle (does not redraw background anymore)
> - New game (does not redraw background anymore)
> - Change background in settings (redraws the background)
> - Changing layout in settings (Create new game with the new layout, do not redraw background)
> - Changing tileset in settings (Recreate tileset, do not redraw background)
> - Load saved game with different background (redraws the background)
> - Resize the window (redraws the background)
> 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150712/09e65996/attachment.html>


More information about the kde-games-devel mailing list