[Kde-games-devel] Review Request 124033: Increasing the ball size automatically.

Albert Astals Cid aacid at kde.org
Sun Jul 12 14:29:15 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124033/#review82387
-----------------------------------------------------------


Did you and Ícaro submit the same feature almost the same day? https://git.reviewboard.kde.org/r/124022/

Could you both agree on what's the better implementation so we have less stuff to review?

- Albert Astals Cid


On jun. 7, 2015, 4:52 p.m., Leonardo Gama wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124033/
> -----------------------------------------------------------
> 
> (Updated jun. 7, 2015, 4:52 p.m.)
> 
> 
> Review request for KDE Games, Filipe Saraiva, Lamarque Souza, and Sandro Andrade.
> 
> 
> Repository: kollision
> 
> 
> Description
> -------
> 
> Kollision is a game that the player drags a blue ball and tries to avoid colliding with red balls. This patch includes a new feature, that increase the ball size over time. And the growth rate is defined by chosen difficulty.
> 
> The implementation of this feature, for structure effects, modify one method and create two new methods that was referred by the new attribute of the class Ball: growth_rate. The method "radius" of the class MainArea was modified for the radius to be refreshed in each state of execution.
> 
> For more details check the diff file.
> 
> 
> Diffs
> -----
> 
>   ball.h 80fbda1 
>   ball.cpp ae7d691 
>   mainarea.cpp b7da2e4 
> 
> Diff: https://git.reviewboard.kde.org/r/124033/diff/
> 
> 
> Testing
> -------
> 
> The game compiles and the new feature works.
> 
> 
> Thanks,
> 
> Leonardo Gama
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150712/12be5065/attachment.html>


More information about the kde-games-devel mailing list