[Kde-games-devel] Review Request 123950: [kbreakout] Restore debugging/cheat codes

[Albert Astals Cid]

El Dilluns, 22 de juny de 2015, a les 07:56:55, Albert Astals Cid va escriure:
> El Divendres, 5 de juny de 2015, a les 11:52:03, Peter Nowee va escriure:
> > Hi,
> > 
> > Viranch tells me he is no longer maintaining this game. Is someone else
> > interested in reviewing my patch, or can I just request git push rights
> > and
> > push it to master myself?
> 
> If noone has, i'll have a look at it, eventually (still fighting post
> holidays too-many-email syndrome).

Commited.

> But if you're interested in developing the game, please sure do send more
> patches :)

Remember keep sending the patches in!

Cheers,
  Albert

> 
> Cheers,
>   Albert
> 
> > Thanks,
> > Peter
> > 
> > 
> > On Sun, May 31, 2015 at 7:51 AM, Peter Nowee <peter.nowee+kde at gmail.com>
> > 
> > wrote:
> > >    This is an automatically generated e-mail. To reply, visit:
> > > https://git.reviewboard.kde.org/r/123950/
> > > 
> > >   Review request for KDE Games and Viranch Mehta.
> > > 
> > > By Peter Nowee.
> > > 
> > >  *Bugs: * 165171 <http://bugs.kde.org/show_bug.cgi?id=165171>
> > >  *Repository: * kbreakout
> > > 
> > > Description
> > > 
> > > Restore debugging/cheat codes
> > > 
> > > This changeset restores the debugging/cheat codes that were left out
> > > 
> > > of the QtQuick port (version 4.9.90, commits 5043da7 and f8f3491):
> > >    - S = Skip level
> > >    - L = Add life
> > > 
> > > These cheat codes are invaluable when designing and testing levels,
> > > as my son likes to do.
> > > 
> > > Like before, all this will only be available when the KDE_DEBUG
> > > environment variable is true, for example:
> > > 
> > > KDE_DEBUG=1 kbreakout
> > > 
> > >  The key shortcuts (default: "S", "L") can now also be configured
> > >  through
> > > 
> > > the menu (provided KDE_DEBUG is true).
> > > 
> > > CCBUG: 165171
> > > 
> > >   Testing
> > > 
> > > Successfully built using:
> > >    - current master of kbreakout (commit 4ad76c6)
> > >    - libkdegames 15.04.1
> > > 
> > > Tested functionality. Everything seems to work as expected.
> > > 
> > > Tested that without KDE_DEBUG set to true, the cheat keys do not work
> > > and do not show up in Configure Shortcuts.
> > > 
> > >   Diffs
> > >   
> > >    - src/canvaswidget.h (c3ae6a6e5b4119ab6c77bb04fe67863cbe7294cc)
> > >    - src/canvaswidget.cpp (341aa16cb573931067d2c7f80be14502c34d23d8)
> > >    - src/mainwindow.h (a371b4bae1f5b0ecbd9be7055694644dfdb69127)
> > >    - src/mainwindow.cpp (c3291a01fa79829d43a0b9e910708f1cfb7df3ac)
> > >    - src/qml/logic.js (c43d0d46ceda523d0e7a14d8ba8bd8b4b73c9767)
> > >    - src/qml/main.qml (d681ad3b15dcf8a67e873591457b36fe1f58a720)
> > > 
> > > View Diff <https://git.reviewboard.kde.org/r/123950/diff/>
> 
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel