[Kde-games-devel] Review Request 122211: [libkdegames] Make tests optional

Thu Jan 22 21:06:01 UTC 2015

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122211/
-----------------------------------------------------------

(Updated Jan. 22, 2015, 9:06 p.m.)

Review request for KDE Games.

Repository: libkdegames

Description (updated)
-------

Qt5Test should not be mandatory, patch to add tests subdirs only if BUILD_TESTING and moved find_package(Qt5Test...) into the respective tests CMakeLists.txt

I should add that I don't have write access, so I ask for someone else to merge it.

Diffs
-----

  CMakeLists.txt 2664fd4ea3234bfe6f9c7d4062579e91adc163fe 
  libkdegamesprivate/CMakeLists.txt b122f37abe1b403042c347c5ad4ff5d37e3dffba 
  libkdegamesprivate/tests/CMakeLists.txt 59ac2b4be7d35eb9518d277379ad53a7f00e5171 
  tests/CMakeLists.txt 7b95e60cd11119b745e8c6830f1514a61fb0c6e1 

Diff: https://git.reviewboard.kde.org/r/122211/diff/

Testing
-------

Built with and without tests.

Thanks,

Andreas Sturmlechner

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150122/18cfe255/attachment.html>