[Kde-games-devel] Review Request 122105: Fix KgDifficulty saving on app close

[Albert Astals Cid]

> On gen. 19, 2015, 2:43 p.m., Kevin Funk wrote:
> > Can't you `Q_ASSERT(qApp)` in `KSharedConfig::openConfig()` in order to make sure people don't do that?

There's already a warning.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122105/#review74330
-----------------------------------------------------------


On gen. 17, 2015, 9:48 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122105/
> -----------------------------------------------------------
> 
> (Updated gen. 17, 2015, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Games.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Since you can't use KSharedConfig::openConfig from a static destructor anymore (the QCoreApplication is gone and thus can't find the name of the thing) use a post routine to save the level before the QCoreApplication is gone.
> 
> KF5 people: Is this something worth mentioning on the porting notes or using KSharedConfig::openConfig from a static destructor is a bit of a corner case anyway?
> 
> 
> Diffs
> -----
> 
>   kgdifficulty.cpp 94489c7 
> 
> Diff: https://git.reviewboard.kde.org/r/122105/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150119/f2b89a59/attachment.html>