[Kde-games-devel] Review Request 122105: Fix KgDifficulty saving on app close
Laurent Montel
montel at kde.org
Sat Jan 17 17:47:20 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122105/#review74190
-----------------------------------------------------------
Ship it!
seems good for me.
Ship it
- Laurent Montel
On jan. 17, 2015, 11:53 matin, Albert Astals Cid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122105/
> -----------------------------------------------------------
>
> (Updated jan. 17, 2015, 11:53 matin)
>
>
> Review request for KDE Frameworks and KDE Games.
>
>
> Repository: libkdegames
>
>
> Description
> -------
>
> Since you can't use KSharedConfig::openConfig from a static destructor anymore (the QCoreApplication is gone and thus can't find the name of the thing) use a post routine to save the level before the QCoreApplication is gone.
>
> KF5 people: Is this something worth mentioning on the porting notes or using KSharedConfig::openConfig from a static destructor is a bit of a corner case anyway?
>
>
> Diffs
> -----
>
> kgdifficulty.cpp 94489c7
>
> Diff: https://git.reviewboard.kde.org/r/122105/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Albert Astals Cid
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150117/039db9d7/attachment.html>
More information about the kde-games-devel
mailing list