[Kde-games-devel] Review Request 122025: Use the Qca-qt5 package from Harald

[laurent Montel]

Le Wednesday 14 January 2015 08:57:48 Raymond Wooninck a écrit :


Qca-qt5 was changed see:
Git commit 99128312fb91bc5f8e6320fe052bbaf7648102fe by Ivan Romanov.
Committed on 14/01/2015 at 10:26.
Pushed by iromanov into branch 'qt5'.

Revert "properly support co-existing qt4 and qt5 versions"

It's not properly. Martin Klapetek is not QCA developer. So it's not
correct that he said "Ship it!".

Properly way

cmake -DQCA_SUFFIX=qt5 ...

and in CMakeLists.txt of your project.

find_package(Qca NAMES Qca-qt5)


Please adapts ksirk to make sure that it works correctly.

Thanks