[Kde-games-devel] KMahjongg archaeology

[Albert Astals Cid]

El Divendres, 9 de gener de 2015, a les 21:50:35, Roney Gomes va escriure:
> On Sun, Jan 4, 2015 at 6:22 AM, Ian Wadham <iandw.au at gmail.com> wrote:
> > So now we have divergent streams of work on KMahjongg:
> >   - A released version of KMahjongg, using obsolete graphics,
> >   - Laurent's port of existing KMahjongg to KF5, using obsolete graphics,
> >   - Christian's port of KMahjongg to QGraphicsView --- branch "qgraphic",
> >   unmerged, - The patch in the above ReviewBoard entry,
> >   - A whole slew of Jan-Peter Nilsson's patches on Bugzilla and
> >   ReviewBoard,
> >   
> >     some of which may clash with Christian's "qgraphic" branch.
> > 
> > What to do?  I really hate to see good work slipping away.
> 
> I vote for prioritizing Christian's porting work. The main reasons
> being that we really do not have enough people to maintain the games,
> so when someone arrives and kindly disposes some time to pick one of
> them and move it away from a deprecated and no longer maintained API
> we should grab the opportunity and thankfully accept this person's
> work.
> 
> Of course the same idea applies to Jan-Peter recent patches, but I
> believe the port is more important in this case since there's more
> people familiar to QGraphicsView than to KGameCanvas, which makes the
> game more prone to receiving contributions. Furthermore, we can't
> really afford maintaining a game using an abandoned API.
> 
> So I propose the following: let's merge "qgraphic" into master and
> check whether the bugs fixed by Jan-Peter still persist, 

That looks like a bad idea, you should check qgraphic branch is good before 
merging it into master, what if it's horribly broken, who's going to fix it? 
Is it going to be before release time?

Cheers,
  Albert

> if so, we can
> update his patches so they make sense according to the new code
> structure. I'm sure I can find some time for this and help Jan-Peter
> on that, if he agrees, naturally.
> 
> Cheers, Roney.
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel